Build on publish #79
Merged
Build on publish #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR addresses the issue of missing built artifacts (the lib directory) in the published package by explicitly adding a build step to the publish pipeline.
- Added "npm run build" as a step in the publish workflow
- Ensures that the package includes the built lib directory before publishing
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/publish.yml | Added explicit "npm run build" step to include lib in publish |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Co-authored-by: Copilot <[email protected]>
dgreif
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #75 we switched from karma to wtr; and as part of that the
test&pretestscripts changed:We switched from needing to build the package to run tests, to instead using
wtr's ability to transpile typescript just in time. This results in faster tests, as there's less work to do beforehand, and so we can confidently drop thenpm run buildpretest script.However, our publish pipeline incidentally relied on build being implicitly run. Consequently, when we released
4.2.0it doesn't includeliblike it's supposed to, rendering the package unusable.This PR adds
npm run buildback into the publish pipeline as an explicit step, so thatlibis included in the package again. We should release this as4.2.1.